trino
trino copied to clipboard
Highlight the environment configuration in the database example
Leaving a note since environment
is not apparent initially, is crucial to make the example configuration work and figuring out why the example is not picked up can be frustrating.
Description
Is this change a fix, improvement, new feature, refactoring, or other? docs enhancement Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific) no, docs How would you describe this change to a non-technical end user or system administrator? improve readability
Related issues, pull requests, and links
Documentation
(x) No documentation is needed. () Sufficient documentation is included in this PR. ( ) Documentation PR is available with #prnumber. ( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required. ( ) Release notes entries required with the following suggested text:
# Section
* Fix some things. ({issue}`issuenumber`)
I am on the same page, however I wanted to bold it out since it can cause issues.
test
is just really far on the argument side, so it's easy to miss.
I think @mosabua suggestion is best resolution:
make more explicit in the sample code
Done, does it look ok now?
I think you should update all the sql queries accordingly
Good suggestion, thank you both.