trino
trino copied to clipboard
Use text blocks for multiline queries in `BaseDeltaLakeConnectorSmokeTest`
Description
Draft used for having an overview of how using text blocks for the multilined SQL queries would improve the readability of the tests.
Is this change a fix, improvement, new feature, refactoring, or other? Code cosmetics
Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
N/A
How would you describe this change to a non-technical end user or system administrator?
N/A
CI failure seems related to this change.
Error: io.trino.plugin.deltalake.TestDeltaLakeLegacyWriterConnectorSmokeTest.testCreatePartitionedTableAs Time elapsed: 1.275 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...,
comment varchar[])
WITH (
location...> but was:<...,
comment varchar[
])
WITH (
location...>
...
I guess the failure hit https://github.com/checkstyle/checkstyle/issues/11742 and we need to wait https://github.com/airlift/airbase/pull/323
Error: src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[323] (regexp) RegexpMultiline: Whitespace character before closing parenthesis
Error: src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[457] (regexp) RegexpMultiline: Whitespace character before closing parenthesis
Error: src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[1256] (regexp) RegexpMultiline: Whitespace character before closing parenthesis