Enforcing procedure name args only

[aczajkowski]

Enforcing using named arguments when calling procedure

[aczajkowski]

@martint @electrum applied requested changes + added background on this change motivation. Let me know if this is ok to proceed ?

[aczajkowski]

@martint @electrum Rebased on top of master due to conflicts.

[aczajkowski]

@martint is there any update on this. Should i close this PR ?

[losipiuk]

@martint is there any update on this. Should i close this PR ?

@martint bump

[aczajkowski]

@martint is there any update on this. Should i close this PR ?

@martint bump

@martint any update around your concern here https://github.com/trinodb/trino/pull/10545#discussion_r782365496

[aczajkowski]

@martint @electrum @losipiuk bump

[aczajkowski]

I like it. As @martint says it may be deviating from the SQL spec, but it makes sense in certain situations. In fact, there are entire languages which don't have positional arguments, only named ones.

Also we are not disallowing using positional arguments at all. It's just one procedure definition that disallows it's usage. So our spec is compatible but in some cases we just limit it for a specific use case.

[kokosing]

It's just one procedure definition that disallows it's usage.

From what I see the given procedure was already like that, it already required named arguments. We just remove hack and have dedicated support for such procedures.

@martint let me know if you have any more comments, otherwise I would like to merge it

[kokosing]

Merged, thanks!

[colebow]

Hey, do we think this needs a release note, or is it just better and more clear error handling?

cc @kokosing

[aczajkowski]

@colebow my opinion is that is just internal mechanics.