trino
trino copied to clipboard
trinodb
Introduce LDAP Group Provider
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.
@Praveen2112 Just FYI I'm setting this PR to WIP to rebase latest changes and refactor the code based on that rebase.
@Praveen2112 I'm not sure why, but this PR is removing the jars. So other commit added them by mistake.
:wave: @rimolive - this PR has become inactive. If you're still interested in working on it, please let us know, and we can try to get reviewers to help with that.
We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.
@woowahan-jaehoon It would be good if you can review the code too.
Hi @rimolive. Thank you for message.
But I left company early this year and I also changed job. So I cannot review this PR right now.
I asked to test this PR to teammate who in my before company already but I didn't get that result yet. (cc: @iamhongri)
Maybe I'll return before job, I'll use this usefully. Thank you.
Closing this one out due to inactivity, but please reopen if you would like to pick this back up.
@bitsondatadev What happened with this PR? We also have an LDAP system our internal Bloomberg build of Trino. Perhaps we should make more efforts to get this released to the community.
@dprophet The PR was inactive so it was closed. Maybe we could re-open it if someone is ready to work on it.
It looks like the PR author @rimolive is no longer working on this and hasn't responded so far. If Bloomberg or anyone else wants to open up a PR that contains this work please do and make sure to reference this PR when opening it so that anyone who comes back to this PR will be directed to the new active PR. This PR will only be reopened if @rimolive wants to pick the work back up. I wouldn't wait though since he hasn't responded since we asked in November of last year.
Happy to provide guidance if anyone needs help.
Hi all, I work with @rimolive and can chime in on his behalf. We have been running a development build of this change set in our production Trino deployment for several months, so I can confirm it's stable.
@Praveen2112 I know that @rimolive felt that too much functionality was being requested as part of this initial PR, and that was a hinderance to him being able to get it done (see this comment for an example).
I can ask @rimolive to reopen this PR if the community desires, although our priorities have shifted and we therefore don't have time to extend/update the existing functionality beyond the current change set here.
I'll leave this up to @Praveen2112.
It sounds like this would only be possible if the PR is mostly merged as-is. Praveen if you feel like this PR is pretty close then maybe we can ask @rimolive to do a few small changes and merge it.
If, however, you feel strongly that there's still much that needs to be addressed, perhaps we should let someone else in the community take this one over and run with it.
We have also been using a similar fork of this original plugin internally for quite some time. We are running into needs to formalize this plugin to feed connector specific io.trino.spi.connector.ConnectorAccessControl. Maintaining a plugin outside of the main Trino code base is darn expensive.
After speaking with @Praveen2112, it seems like there are some changes needed before this is ready to be merged. So merging as-is will not be an option. Anyone who is interested in picking up this work is highly encouraged to do so! If you need help, please reach out to me or on the #dev channel on the Trino Slack.