trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard
verified publisher icon trinodb

Make this package PEP-561 compatible by adding a py.typed marker

Open Priyansh121096 opened this issue 1 year ago • 2 comments

Describe the feature

I see that static type checking was discussed in #69 and mypy was enabled in #91. Do people think it's a good idea to add a py.typed marker so that packages depending on trino can type check themselves against it?

Right now, there's no way to force mypy to type check against this site-packages which lack this marker (ref).

Describe alternatives you've considered

No response

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Priyansh121096 avatar Sep 06 '24 12:09 Priyansh121096

Good idea, if you are still willing to send a PR we'd appreciate it. Sorry it took so long to reply.

hashhar avatar Nov 20 '24 08:11 hashhar

Good idea, if you are still willing to send a PR we'd appreciate it. Sorry it took so long to reply.

@hashhar raised #514

Priyansh121096 avatar Jan 13 '25 14:01 Priyansh121096