trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard

[tests] Fix TrinoDialect.has_schema arguments

Open john-bodley opened this issue 2 years ago • 0 comments

Description

This is where type enforcement would be really helpful. For the SQLAlchemy dialect the has_schema method was being passed the SQLAlchemy engine as opposed to the corresponding connection per here. Both objects have an execute(...) method which is why the tests worked, however I thought it was prudent to make make sure the callers used the correct arguments.

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

john-bodley avatar Oct 14 '22 01:10 john-bodley