fix invalid column names

[zinking]

• name typos fixed according to tpcds queries in spark

[cla-bot[bot]]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: zhnwang. This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot[bot]]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

[pan3793]

Ref: https://tpc.org/TPC_Documents_Current_Versions/pdf/TPC-DS_v3.2.0.pdf

[pan3793]

@zinking I think you should follow the tips to sign cla

[pan3793]

@hashhar would you please take a look on this change?

[zinking]

@zinking I think you should follow the tips to sign cla

I remembered I signed presto cla before. anyways, this repo doesn't look active you can just patch back.

[ebyhr]

I signed presto cla before

@zinking This repository isn't managed by PrestoDB. Did you sign CLA of Trino https://github.com/trinodb/cla?

[zinking]

I signed presto cla before

@zinking This repository isn't managed by PrestoDB. Did you sign CLA of Trino https://github.com/trinodb/cla?

ok just signed.

[sopel39]

cc @przemekak

[pan3793]

@zinking would you please check the comments and update the PR?

[zinking]

@zinking would you please check the comments and update the PR?

I was running this result against queries in spark. if your conclusion is right, then it means queries in spark suit are wrong. I'm not sure what's in between.

also please review other occurences

src/main/java/io/trino/tpcds/column/CustomerColumn.java 44: C_LAST_REVIEW_DATE(IDENTIFIER);

src/main/java/io/trino/tpcds/generator/CustomerGeneratorColumn.java 41: C_LAST_REVIEW_DATE(131, 1),

src/main/java/io/trino/tpcds/row/CustomerRow.java 34:import static io.trino.tpcds.generator.CustomerGeneratorColumn.C_LAST_REVIEW_DATE; 120: getStringOrNull(cLastReviewDate, C_LAST_REVIEW_DATE));

src/main/java/io/trino/tpcds/row/generator/CustomerRowGenerator.java 48:import static io.trino.tpcds.generator.CustomerGeneratorColumn.C_LAST_REVIEW_DATE; 98: Date lastReviewDate = generateUniformRandomDate(oneYearAgo, today, getRandomNumberStream(C_LAST_REVIEW_DATE));

[pan3793]

I was running this result against queries in spark. if your conclusion is right, then it means queries in spark suit are wrong.

I think as a library, it should respect the latest TPC-DS standard.

Spark uses the old version queries of TPC-DS, I raised an issue to handle the column name change in downstream project(Kyuubi)

[zinking]

@przemekak what about other occurrences, I think I didn't have errors using that before renaming, should those be kept or changed ?