grafana-trino icon indicating copy to clipboard operation
grafana-trino copied to clipboard

Feature/ticketless client tags in query editor

Open RotRotAl opened this issue 2 months ago • 7 comments

Allows to override the client tags that were set in the data source addition , via the the query editor. Based on pr #309 by @laserninja that allows setting the client tags in the data source addition .

RotRotAl avatar Sep 25 '25 15:09 RotRotAl

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Sep 25 '25 15:09 cla-bot[bot]

Cla was accepted waiting for #309 before i can publish this @laserninja @RoeyoOgen

RotRotAl avatar Oct 21 '25 15:10 RotRotAl

Please squash all commits

nineinchnick avatar Oct 28 '25 09:10 nineinchnick

@RotRotAl can you please create a PR with just your changes? We can get this approved https://github.com/trinodb/grafana-trino/pull/309 meanwhile

laserninja avatar Oct 28 '25 15:10 laserninja

@laserninja sadly my code based on your changes, i will pull your changes after you finish the cr process

RotRotAl avatar Oct 28 '25 15:10 RotRotAl

@nineinchnick done replying and fixing, thanks for the cr.

RotRotAl avatar Oct 29 '25 13:10 RotRotAl

Hi @nineinchnick stil needs second cr 🙏🏻

RotRotAl avatar Nov 02 '25 07:11 RotRotAl

@nineinchnick still waits for cr

RotRotAl avatar Nov 26 '25 16:11 RotRotAl

I need it in order to give my “clients” the ability to choose in which cluster there query should be running, i give them only the gateway link and they decide by client tag where will it run. @nineinchnick

RotRotAl avatar Nov 26 '25 16:11 RotRotAl