charts
charts copied to clipboard
:sparkles: add extraVolumes and extraVolumeMounts tpl rendering
Give the ability to add extraVolumes and extraVolumeMounts. Typically, on a cluster with nonRoot pods strategy (OpenShift), we have to change the dataDir, because it's owned by root (the random uid can't write inside). It would be great to give the possibility to add an emptyDir or pvc.
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
this is pretty useful for getting the JMX java agent working too.
Is anything holding up this merge? We'd also like the capability of mounting the additional volumes.
Hi, I'm pretty keen to use this feature.
I guess this is blocked because the CLA hasn't been signed. (ref). @sebastiendejou are you willing to sign the CLA to get this moving?
If not @lshmouse I saw your PR addressing the same issue. Will you perhaps reopen the PR?
If both of you are reluctant I'm happy to submit the 3rd PR 😃
Since #129 is merged, I'll close this one. Feel free to reopen after rebasing.