charts icon indicating copy to clipboard operation
charts copied to clipboard

:sparkles: add extraVolumes and extraVolumeMounts tpl rendering

Open sebastiendejou opened this issue 1 year ago • 4 comments

Give the ability to add extraVolumes and extraVolumeMounts. Typically, on a cluster with nonRoot pods strategy (OpenShift), we have to change the dataDir, because it's owned by root (the random uid can't write inside). It would be great to give the possibility to add an emptyDir or pvc.

sebastiendejou avatar Mar 28 '23 13:03 sebastiendejou

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 28 '23 13:03 cla-bot[bot]

this is pretty useful for getting the JMX java agent working too.

drish avatar Apr 20 '23 18:04 drish

Is anything holding up this merge? We'd also like the capability of mounting the additional volumes.

doublefelix7 avatar Oct 19 '23 17:10 doublefelix7

Hi, I'm pretty keen to use this feature.

I guess this is blocked because the CLA hasn't been signed. (ref). @sebastiendejou are you willing to sign the CLA to get this moving?

If not @lshmouse I saw your PR addressing the same issue. Will you perhaps reopen the PR?

If both of you are reluctant I'm happy to submit the 3rd PR 😃

koh-satoh-wpg avatar Jan 29 '24 02:01 koh-satoh-wpg

Since #129 is merged, I'll close this one. Feel free to reopen after rebasing.

nineinchnick avatar May 22 '24 07:05 nineinchnick