charts
charts copied to clipboard
Support `pod.spec.containers.securityContext` specification
This PR attempts to close #116
@hashhar sorry to ask you but could you kindly review this, please...? 🙏
Not a maintainer, but I'm wondering if it makes sense to define a default, restrictive securityContext out-of-the-box. Trino should support running as non-root and without privilege (escalation) requirements. Most, if not all, of the bitnami charts do this, e.g. https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L477.
@chgl thank you for your comments! That would be better!
Update this PR following the valeriano-manassero's implementation
@mosabua sorry to ask you but I fixed the commit and rebased this branch to the latest main branch. Could you review this when you have time, please...? 🙏
@mosabua thank you for your review! I have amended the commit to update the description! could you check this again, please...?
How about keeping all of the security context open to values.yaml
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
EDIT: Ignore you did exactly that
@bond- Thank you for your comment! yes, that's exactly what I did in the first place. But I set the default following the comment in this review by amending the commit 🙇
@LittleWat please rebase, and I'll review this once the new tests in the CI pass.
@nineinchnick thanks! rebased!
@nineinchnick thank you for your quick review! yes, that would be better! Fixed!