charts icon indicating copy to clipboard operation
charts copied to clipboard

[catalogs] use secrets

Open luismacosta opened this issue 2 years ago • 8 comments

Hello,

Once catalogs have username/password, instead of configmap use a secret Note: I'm also using this secrets approach to configure authentication with password file + ldap, in order to create the property files (I've seen this approach for ldap, but I would rather avoid to use env vars with passwords)

luismacosta avatar Dec 05 '23 23:12 luismacosta

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Dec 05 '23 23:12 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Dec 06 '23 00:12 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Dec 06 '23 00:12 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Jan 28 '24 18:01 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Jan 28 '24 19:01 cla-bot[bot]

This is a good improvement!

Worth noting in changelog as breaking tho

philicious avatar Jan 29 '24 00:01 philicious

@luismacosta could you sign the CLA to unblock this PR? I'm not a contributor but would like to use this change..

chulkilee avatar Mar 01 '24 20:03 chulkilee

@luismacosta can you rebase and address comments?

nineinchnick avatar May 22 '24 08:05 nineinchnick

This looks abandoned.

nineinchnick avatar Aug 24 '24 08:08 nineinchnick