charts icon indicating copy to clipboard operation
charts copied to clipboard

add ldap support for password auth

Open derbeneviv opened this issue 1 year ago • 9 comments

Hi all!
Thanks for a great chart, but it lacks some functionality.

In our environment we needed to use a ldap auth, so i've added this to a chart, and am hoping this can be merged to upstream

derbeneviv avatar Nov 03 '23 09:11 derbeneviv

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 03 '23 09:11 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 03 '23 10:11 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 03 '23 10:11 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 03 '23 10:11 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Nov 03 '23 10:11 cla-bot[bot]

@derbeneviv are you still interested in working on this? We should have tests for this, which would require running an LDAP server. Maybe we can discuss how to best do this.

nineinchnick avatar May 22 '24 08:05 nineinchnick

Hi @nineinchnick we are interested in add this support, maybe i can continue with this work but as far i see seen promising and dont need much changes

alexagc avatar May 22 '24 14:05 alexagc

@alexagc can you always open up a second PR with these changes. The implementation looks fine, but it definitely needs tests.

nineinchnick avatar May 22 '24 15:05 nineinchnick

sorry for the delayed response i'm interested (well i've implemented it in my fork) but i'm not really ready to sign any legal documents.
you can freely use any code from this PR

derbeneviv avatar Jul 16 '24 09:07 derbeneviv

We cannot accept any contributions without the CLA, so I have to close this.

nineinchnick avatar Aug 24 '24 08:08 nineinchnick