Add github.user argument to p_install family?

[Dasonk]

trafficstars

I was thinking about p_temp and how it might be nice to be able to temporarily install packages from github. We would need to include some sort of github.user parameter to allow this (and not to mention we would need to require devtools).

Would this be worthwhile to attempt?

[trinker]

I think so. This is where people are especially likely to temporary 'try on' a package.

[trinker]

I'm working on this problem. Do you think we could use:

dev_mode(on=T)
install_github(...)

Or should the link to the package remain until the end of the session (i.e., this is not equivalent to what p_temp does.). My feeling is we need another work around. Let me know if this is not clear.

[Dasonk]

I don't think we'll need to do anything special actually. We use p_install inside of p_temp so we just need to 1) get p_install to be able to install from github 2) add ... parameter to p_temp and 3) pass that on to p_install inside of p_temp.

I plan on taking care of a bunch of issues over the weekend. Tomorrow we're driving back to ames, Thursday I'm doing a bunch of prep work for the start of class next week, Friday I have a ton of meetings but Saturday... well Saturday I can work on this.

[dpastoor]

Don't know if you guys want another contributor to take a crack at it but I was thinking something along the lines of:

Initially I was thinking to have an any_github = T/F argument

Then if T extract any packages with the nomenclature <gh_user>/ and pass those through to install_github but in looking @ the source code for install-github it looks like there are enough customization options w/ subdirectories or branches that it would likely be easier to require the the user to specify a second argument github_package rather than trying to parse which elements in the packages vector were cran vs github.

If you guys are up for it I could take a crack at either:

adding the additional argument install_github and simply adding a imports devtools or pull the necessary functions from devtools and don't export them to prevent conflicts