modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Storybook has a Node v18 compatibility issue

Open coliff opened this issue 3 years ago • 4 comments

Although we should address/fix the issue at some point, for now we should specify the compatible Node versions in the package.json.

Then users will be warned when running npm install if they have Node v18 (or Node v14 which is no longer actively supported).

  "engines": {
    "npm": ">=8.0.0 <9.0.0",
    "node": ">=16.0.0 <17.0.0"
  },

I think issue is related to this: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V17.md#openssl-30

coliff avatar Dec 01 '22 10:12 coliff

@coliff If this will be resolved by https://github.com/trimble-oss/modus-web-components/issues/1143, we can close the issue. What do you think?

msankaran0712 avatar Nov 10 '23 07:11 msankaran0712

I don't mind closing this issue if you want to. I'm fine to keep it open too.

coliff avatar Nov 11 '23 01:11 coliff

Looks like this issue is now resolved and we are able run with latest node version so closing this. @coliff please reopen if we have to handle anything.

prashanth-offcl avatar Sep 09 '24 14:09 prashanth-offcl

This is related to storybook package.json which still have the specific node version defined so we have to check if the latest storybook upgrade #1143 solves this issue.

prashanth-offcl avatar Sep 09 '24 14:09 prashanth-offcl