modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Standardize input values for size prop

Open msankaran0712 opened this issue 3 years ago • 6 comments

Any component should have standard input values for the size prop.

Should that be 'small', 'medium', and 'large' ? or just 'condensed', 'default', and 'large' ?

@ryan-henness-trimble @coliff

msankaran0712 avatar Aug 22 '22 07:08 msankaran0712

yes, agreed. we should try and use small instead of condensed where possible. If class condensed exists already maybe it could be deprecated and available as an alias for small.

Note; not all components are available in all sizes though.

coliff avatar Aug 22 '22 07:08 coliff

yes, agreed. we should try and use small instead of condensed where possible. If class condensed exists already maybe it could be deprecated and available as an alias for small.

Note; not all components are available in all sizes though.

Yes agreed.

msankaran0712 avatar Aug 22 '22 07:08 msankaran0712

Review where we stand today, list out all variations here to determine next steps.

cjwinsor avatar Apr 19 '24 14:04 cjwinsor

Hello world

mitch-trimble avatar Aug 29 '24 14:08 mitch-trimble

@prashanthr6383 @mitch-trimble Let's review this one in the Three Amigos meeting.

enowak1031 avatar Aug 29 '24 14:08 enowak1031

@prashanthr6383 @mitch-trimble Let's review this one in the Three Amigos meeting.

@prashanth-offcl please check

prashanthr6383 avatar Aug 30 '24 05:08 prashanthr6383