modus-web-components
modus-web-components copied to clipboard
trimble-oss
Slider: fix modus slider selection
Description
There is no difference in the visibility of selected and non selected part of the slider as the entire part is shown in blue color.
https://deploy-preview-3026--moduswebcomponents.netlify.app/?path=/story/components-slider--default
References #2717
Deploy Preview for moduswebcomponents ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 77e4ff787b47e2aa73022382f556a5eaca42d948 |
| Latest deploy log | https://app.netlify.com/projects/moduswebcomponents/deploys/68590b93ca25d40008a14eea |
| Deploy Preview | https://deploy-preview-3026--moduswebcomponents.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 21 (🔴 down 13 from production) Accessibility: 75 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
https://deploy-preview-3026--moduswebcomponents.netlify.app/?path=/story/components-slider--default
This doesn't appear to be working...
@SuruthiShriP - Build is failing - please run tests locally to ensure all is working before committing changes. Thanks!
@SuruthiShriP - Build is failing - please run tests locally to ensure all is working before committing changes. Thanks!
My local tests are running successfully, but not sure why its failing here. Can you please help me?
Yes, the disabled state should be gray. The slider design in this PR is good, an improvement, but it's actually different to what appears on the Figma file (which doesn't have a different color for the selected range).
We need input from: @enowak1031 and @mitch-trimble if we can proceed with this.