modus-web-components
modus-web-components copied to clipboard
Table: Row Action Column Accessibility issues
Description
- Added a title to the row actions column header.
- Replaced the cancel icon in the row actions with the cancel_circle icon.
References Fixes #2886
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation update
How Has This Been Tested?
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
- [x] I have checked my code and corrected any misspellings
Deploy Preview for moduswebcomponents ready!
| Name | Link |
|---|---|
| Latest commit | c77dcb6bcd6acaa10027e84ec548b2333780930f |
| Latest deploy log | https://app.netlify.com/sites/moduswebcomponents/deploys/673d93357a6e02000898a71c |
| Deploy Preview | https://deploy-preview-2887--moduswebcomponents.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 23 (🔴 down 1 from production) Accessibility: 98 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
compared: https://deploy-preview-2887--moduswebcomponents.netlify.app/?path=/story/components-table--row-actions to: https://moduswebcomponents.netlify.app/?path=/story/components-table--row-actions
Fix looks good!
This PR will have to wait until #2874 is merged.
