modus-web-components
modus-web-components copied to clipboard
trimble-oss
Button: add critical action feature
Description
References
Fixes #1439
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update
How Has This Been Tested?
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
- [x] I have checked my code and corrected any misspellings
Deploy Preview for moduswebcomponents ready!
| Name | Link |
|---|---|
| Latest commit | 576c97c7ca7249568e62ec29176718d7b01da3b4 |
| Latest deploy log | https://app.netlify.com/sites/moduswebcomponents/deploys/674483f05365eb00089065da |
| Deploy Preview | https://deploy-preview-2871--moduswebcomponents.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 41 (🔴 down 6 from production) Accessibility: 75 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can we make "Accessibility Warning" text bold and remove the comma before "as." Otherwise, it's good to go :)
@prashanthr6383 By default, the critical-action in Storybook is set to true, but it should be changed to false.
@jewel-shajan I have updated now please check
Can we make "Accessibility Warning" text bold and remove the comma before "as." Otherwise, it's good to go :)
@enowak1031 changes updated.
This doesn't work on iPad (Tested on iPad Pro with iPadOS 18.2)
@coliff Added the support for touch screen devices.