modus-web-components
modus-web-components copied to clipboard
trimble-oss
[Modus-Table] Allow translated strings for pagination and sorting.
Prerequisites
- [X] I have searched for duplicate or closed feature requests
- [X] I have read the Modus style guidelines
Proposal
The modus-table component contains some hardcoded English strings. As shown in the below screenshot:
As a developer I would like to be able to provide custom values for these strings, so that I can support multiple languages.
Motivation and context
We are planning to release a UI component, that uses the modus-table, which will be used in a multi-language product.
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
High
What product/project are you using Modus Components for ?
Nova / Construction calculation platform UI
What is your team/division name ?
ACDC
Are you willing to contribute ?
Maybe
Are you using Modus Web Components in production ?
No response
Hello @janwiebe-glasbergen! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.
Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@prashanth-offcl to check and decide on the approach for translation.
Hi @prashanth-offcl attached the analysis documentation for this ticket. Kindly refer https://docs.google.com/document/d/1qtB8AmoEUqhIJEOQ3yXJ3MLfOPa4di-qkPZ3j9MvdIQ/edit?tab=t.0
We think we should support French, Finnish, Spanish, German, and Italian to begin with. But would like to start with the requester's language. It appears to be French. Could you @janwiebe-glasbergen provide appropriate translations and confirm the language?
Prashanth talked to the requester. He needs French and German and later Dutch.