modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Modus Table: Fixed uneven width on rowSelection and rowAction columns

Open venkyn13 opened this issue 1 year ago • 9 comments

Description

  1. Fixed uneven width on rowSelection and rowAction columns by making it's width as 30px. This worked fine only after adding table-layout: fixed style.
  2. Please find below attached gif. Modus-Bug-UnevenWidth
  3. Still it not fine when i remove fullWidth and I am looking forward for few hints to fix this too

References #1922

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

venkyn13 avatar Jan 11 '24 05:01 venkyn13

Deploy Preview for modus-webcomponents failed.

Name Link
Latest commit 0a0a7b052b16c29453e21f5f775499953bdc6619
Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/659fb5dbb1c8b100081f2f5e

netlify[bot] avatar Jan 11 '24 05:01 netlify[bot]

Build failing: image

coliff avatar Jan 11 '24 09:01 coliff

Build failing: image

@coliff May i know, what may be the reason, I ran lint already, apart from style, I haven't touched any part

venkyn13 avatar Jan 11 '24 09:01 venkyn13

Build failing: image

@coliff May i know, what may be the reason, I ran lint already, apart from style, I haven't touched any part

npm run test (from stencil-workspace directory) runs the tests.

coliff avatar Jan 11 '24 15:01 coliff

@coliff image

venkyn13 avatar Jan 16 '24 06:01 venkyn13

I'm not sure about that Puppeteer error. Check the Node version you have and use Node v16 if possible. Also please squash commits in your PR if you can and fetch latest changes from main branch.

coliff avatar Jan 16 '24 08:01 coliff

Deploy Preview for moduswebcomponents failed.

Name Link
Latest commit dd67b0d5ac870c6b6162896af888f619067eb6e3
Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/65a77a7a492fdd0008c52750

netlify[bot] avatar Jan 17 '24 06:01 netlify[bot]

I'm not sure about that Puppeteer error. Check the Node version you have and use Node v16 if possible. Also please squash commits in your PR if you can and fetch latest changes from main branch.

Reverting to node v16 also didn't work

venkyn13 avatar Jan 19 '24 10:01 venkyn13

I can run the tests and 3 tests are failing. I am looking at it now.

rthanga1 avatar Jan 24 '24 13:01 rthanga1