modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Allow tabs to be set using slots

Open AlexRaynerTrimble opened this issue 2 years ago • 2 comments

Prerequisites

Proposal

Currently using the tabs component is done so by providing an object list of the tabs to add. This poses an issue for us when supplying translation strings in angular, since the html template is responsible for translating; I imagine this is a more general issue with translations that isn't specific to angular.

I'm proposing altering the way tabs work to use slotted content for each tab (a good example of this can be found here). This makes it much easier for an implementer to use the tabs component.

Additionally, tab components tend to include slots for the content to display when each tab is active. This is less of a requirement and more of a nice to have if possible.

Motivation and context

Providing component layout via an object rather that through slotted/projected content is not a developer friendly way of doing things. It also requires that the implementer looks after the state of the current active tab in order to render content relating to the tab. This is something the Modus component could do for us.

What is the issue regarding ?

@trimble-oss/modus-web-components, @trimble-oss/modus-angular-components

Priority

Low

What product/project are you using Modus Components for ?

Predesign, AddLocation, Spaces

What is your team/division name ?

Habitat/SketchUp

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

no

AlexRaynerTrimble avatar Nov 13 '23 09:11 AlexRaynerTrimble

Hello @AlexRaynerTrimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

github-actions[bot] avatar Nov 13 '23 09:11 github-actions[bot]

Maha and Ramaraj to discuss offline.

rthanga1 avatar Dec 01 '23 14:12 rthanga1