dba-dash
dba-dash copied to clipboard
trimble-oss
Issue with 6.0.2 SDK update
The issue is described here: https://github.com/dotnet/winforms/issues/6663
Since upgrading to the latest VS, the application builds with 6.0.2 and will fail to run on a machine without this version installed. The app fails silently and you have to discover the error using event viewer.
Ideally you would at least be prompted to upgrade to the new version.
As a workaround we can use 6.0.101 be specifying this in the Global.json and editing the workflows to use 6.0.101. At some point we might want to revert this change and upgrade to a newer version.
Global.json has been removed #220. Project is still built with 6.0.101 on the github action for wider compatibility.
It looks like the backward compatibility might be broken now? The action is still targeting 6.0.101 - not sure when/how this got broken. It might be useful to investigate. Maybe just use the latest version now and ensure this is called out in the docs?
This was first broken in 2.22.9. Most likely it was introduced by this commit to bump the setup-dotnet action.
Changing actions/setup-dotnet@v3 to actions/setup-dotnet@v2 fixes the issue. It might be time to move to the new version though and run a check in the upgrade script.
GH Actions have now been updated to use the latest version. Backward compatibility issue is documented.