Tpetra: change logic in Tpetra::CrsMatrix::CombineGlobalValues

[jhux2]

Enhancement

@trilinos/tpetra

At the 2021-Sept-21 Tpetra developer meeting, it was decided to modify the logic in Tpetra::CrsMatrix::CombineGlobalValues(). Instead of depending on

if (isStaticGraph ()) {
...
} else {
...
}

the appropriate method, e.g., sumIntoGlobalValues, should be unconditionally called, and its return value checked to determine success or failure.

This is to resolve #9720.

[jhux2]

This comment is concerning because it implies the return value won't always indicate whether the modification was successful. https://github.com/trilinos/Trilinos/blob/e0adf23dfd61bca77cb13bc4c13f5432e188fd52/packages/tpetra/core/src/Tpetra_CrsMatrix_def.hpp#L2783

[jhux2]

@csiefer2

[jhux2]

Two questions were posed at this week's Tpetra meeting:

1. Are all the cases in #9778 hit by a Tpetra unit test.

   The answer is "no". ABSMAX is not reached. All other cases are reached.

2. #9778 needs a unit test.

[github-actions[bot]]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions[bot]]

This issue was closed due to inactivity for 395 days.