Trilinos icon indicating copy to clipboard operation
Trilinos copied to clipboard

Zoltan2: CoordinateModel holds on to two copies of coordinates and should be cleaned up not to cache

Open bathmatt opened this issue 3 years ago • 1 comments

Enhancement

@trilinos/zoltan2

Looking into the coordinate model in Zoltan2 I've ran into an issue in UVM removal where this model would grab two copies of the coordinates, one host and one device. The problem is that tpetra won't let you do this anymore unless you're using UVM.

I've made a deep copy in my branch so I have a copy of the coordinates which works around this problem. However it is not ideal, this issue is to fix that.

Secondly this model grabs an unref counted pointer of the host coords, this is bad as if that data goes out of scope then it can point to nothing. That should be resolved as well

bathmatt avatar Jul 06 '21 17:07 bathmatt

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] avatar Jul 23 '22 12:07 github-actions[bot]

@JacobDomagala This issue is related to your PR 10184 https://github.com/trilinos/Trilinos/pull/10184/

egboman avatar Aug 25 '22 11:08 egboman