ShyLu/Tacho: Tacho's unit test use tacho-gtest.so, but they don't link pthreads

[jjellio]

Bug Report

If you configure Tacho with tests ON, tacho builds it's own Gtest (libtacho-gtest.so), but that lib needs to depend on -lpthread

The key part of this error is:

ld.lld: error: undefined reference due to --no-allow-shlib-undefined: pthread_key_create
>>> referenced by packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5

This seems to be an issue with all Tacho tests.

FAILED: packages/shylu/shylu_node/tacho/unit-test/Tacho_Test_ETI_float_Serial.x 
: && /p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/build_stat_cxx_wrapper.sh -x hip -mllvm -amdgpu-early-inline-all=false -mllvm -amdgpu-function-calls=false -g -march=znver3 -mtune=znver3 -fno-gpu-rdc -xhip --rocm-path=/opt/rocm-5.7.0 --offload-arch=gfx90a  -O3 -DNDEBUG -x none --hip-link     -DKOKKOS_DEPENDENCE -march=znver3 -mtune=znver3 -fno-gpu-rdc packages/shylu/shylu_node/tacho/unit-test/CMakeFiles/Tacho_Test_ETI_float_Serial.x.dir/eti/Tacho_Test_ETI_float_Serial.cpp.o -o packages/shylu/shylu_node/tacho/unit-test/Tacho_Test_ETI_float_Serial.x  -Wl,-rpath,/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/shylu/shylu_node/tacho/unit-test:/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/shylu/shylu_node/tacho/src:/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/kokkos/simd/src:/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/kokkos/algorithms/src:/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/kokkos/containers/src:/p/lustre1/jjellio/collab/amd-5.7.0_prgenv-amd_rocm-5.7.0_mpich-8.1.27_pure-amd_hip_amd-NOinlall-NOfunc-gfx90a_serial_atdm_complex_opt-g_cxx17/trilinos/packages/kokkos/core/src  packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5  packages/shylu/shylu_node/tacho/src/libtacho.so.14.5  packages/kokkos/simd/src/libkokkossimd.so.14.5  packages/kokkos/algorithms/src/libkokkosalgorithms.so.14.5  packages/kokkos/containers/src/libkokkoscontainers.so.14.5  packages/kokkos/core/src/libkokkoscore.so.14.5  /usr/lib64/libdl.so  /opt/rocm-5.7.0/lib/libhipsolver.so  /opt/rocm-5.7.0/lib/librocsolver.so  /opt/rocm-5.7.0/lib/libhipblas.so  /opt/rocm-5.7.0/lib/librocblas.so  /opt/rocm-5.7.0/lib/libhipsparse.so  /opt/rocm-5.7.0/lib/librocsparse.so  /opt/rocm-5.7.0/lib/libamd_comgr.so  /opt/rocm-5.7.0/lib/libhsa-runtime64.so  /opt/rocm-5.7.0/lib/libamdhip64.so  /p/lustre1/jjellio/spack/install/linux-rhel8-zen3/rocmcc-5.7.0/metis-5.1.0-b47vofodrh5k6lllor6jxp4yrlwwt2p7/lib/libmetis.a  /p/lustre1/jjellio/spack/install/linux-rhel8-zen3/rocmcc-5.7.0/openblas-0.3.23-h7bvflv4ag7kiybca26sertgdyqsa6rb/lib/libopenblas.a  /p/lustre1/jjellio/spack/install/linux-rhel8-zen3/rocmcc-5.7.0/openblas-0.3.23-h7bvflv4ag7kiybca26sertgdyqsa6rb/lib/libopenblas.a && :
clang++: warning: argument unused during compilation: '-mllvm -amdgpu-early-inline-all=false' [-Wunused-command-line-argument]
clang++: warning: argument unused during compilation: '-mllvm -amdgpu-function-calls=false' [-Wunused-command-line-argument]
ld.lld: error: undefined reference due to --no-allow-shlib-undefined: pthread_key_create
>>> referenced by packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5

ld.lld: error: undefined reference due to --no-allow-shlib-undefined: pthread_getspecific
>>> referenced by packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5

ld.lld: error: undefined reference due to --no-allow-shlib-undefined: pthread_key_delete
>>> referenced by packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5

ld.lld: error: undefined reference due to --no-allow-shlib-undefined: pthread_setspecific
>>> referenced by packages/shylu/shylu_node/tacho/unit-test/libtacho-gtest.so.14.5
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

@trilinos/shylu @iyamazaki