trilinos
Piro: Implicit test dependency on Amesos
If I enable Piro and its tests without enabling Amesos, I get a number of errors:
/home/etphipp/project/Trilinos/Trilinos/packages/piro/test/Piro_MatrixFreeDecorator_UnitTests.cpp:56:10: fatal error: 'Thyra_AmesosLinearOpWithSolveFactory.hpp' file not found
/home/etphipp/project/Trilinos/Trilinos/packages/piro/test/Piro_NOXSolver_UnitTests.cpp:58:10: fatal error: 'Thyra_AmesosLinearOpWithSolveFactory.hpp' file not found
/home/etphipp/project/Trilinos/Trilinos/packages/piro/test/Piro_LOCASolver_UnitTests.cpp:58:10: fatal error: 'Thyra_AmesosLinearOpWithSolveFactory.hpp' file not found
/home/etphipp/project/Trilinos/Trilinos/packages/piro/test/Piro_TempusSolver_UnitTests.cpp:68:10: fatal error: 'Thyra_AmesosLinearOpWithSolveFactory.hpp' file not found
/home/etphipp/project/Trilinos/Trilinos/packages/piro/test/Piro_TempusSolver_SensitivityUnitTests.cpp:69:10: fatal error: 'Thyra_AmesosLinearOpWithSolveFactory.hpp' file not found
Explicitly enabling Amesos resolves the errors, so Amesos needs to be added as a required test dependency in piro/cmake/Dependencies.cmake, or as an optional test dependency with the above tests conditionally disabled if Amesos is not present.
@trilinos/piro
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.
@mperego, can you look at this? This will need to be resolved for the Epetra-Tpetra Transition.
I can look into this. However, this issue is related to the "legacy" Epetra code. These tests are already disabled when building with Tpetra only.
Ok, it sounds like there is some odd logic here? Tests enabled with Epetra enabled without Amesos enabled? And tests disabled with Tpetra enabled? Something like that?
My understanding is that the issue appears when Epetra is enabled but Amesos is disabled. Not sure it is worth fixing it since we are moving away from Epetra and Piro is not used that much. But I can fix it if you think it is worth it.
I am ok with not worrying about this, so long as it will not cause an issue during Epetra-Tpetra transition (it does not sound like it would). @etphipp are you ok with this path forward? If so, let's close this.
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.