oauth2-bundle
oauth2-bundle copied to clipboard
trikoder
[WIP] Add documentation for authorization code grant
Codecov Report
Merging #177 (854faf9) into v3.x (119fa85) will increase coverage by
0.59%. The diff coverage isn/a.
@@ Coverage Diff @@
## v3.x #177 +/- ##
============================================
+ Coverage 90.89% 91.48% +0.59%
- Complexity 367 454 +87
============================================
Files 56 66 +10
Lines 1208 1621 +413
============================================
+ Hits 1098 1483 +385
- Misses 110 138 +28
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| OAuth2Grants.php | 0.00% <0.00%> (-100.00%) |
1.00% <0.00%> (ø%) |
|
| .../Exception/Oauth2AuthenticationFailedException.php | 0.00% <0.00%> (-100.00%) |
1.00% <0.00%> (ø%) |
|
| Model/RedirectUri.php | 29.62% <0.00%> (-53.71%) |
15.00% <0.00%> (+12.00%) |
:arrow_down: |
| Event/UserResolveEvent.php | 38.46% <0.00%> (-17.10%) |
5.00% <0.00%> (-4.00%) |
|
| Model/Client.php | 87.17% <0.00%> (-5.93%) |
19.00% <0.00%> (+7.00%) |
:arrow_down: |
| Security/Authentication/Token/OAuth2Token.php | 91.66% <0.00%> (-3.21%) |
9.00% <0.00%> (-7.00%) |
|
| Manager/InMemory/ClientManager.php | 18.18% <0.00%> (-0.87%) |
12.00% <0.00%> (ø%) |
|
| League/Entity/Scope.php | 100.00% <0.00%> (ø) |
1.00% <0.00%> (ø%) |
|
| Converter/ScopeConverter.php | 100.00% <0.00%> (ø) |
4.00% <0.00%> (ø%) |
|
| Command/CreateClientCommand.php | 100.00% <0.00%> (ø) |
8.00% <0.00%> (+4.00%) |
|
| ... and 30 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 119fa85...854faf9. Read the comment docs.
@okazy Thank you for your feedback, I have committed your suggestions and added some additional changes for listener example.
Regarding authorization confirmation page, I don't know best practice for creating it.
@HypeMC What do you think, maybe open new issue for best practice of creating authorization confirmation page? Also, maybe we should open issue (or include in best practice issue) explaining what is best practice for restricting scopes on authorization server? (I don't have that use-case in my applications so I can't recommend anything)
