oauth2-bundle icon indicating copy to clipboard operation
oauth2-bundle copied to clipboard

Published 20 hours ago • verified publisher icon trikoder

OpenID Connect

Open MichaelKubovic opened this issue 5 years ago • 7 comments

Thanks to @ajgarlag we have a working, OIDC-compliant integration.

The code in this PR covers:

  • steverhoades/oauth2-openid-connect-server integration
  • adds support for nonce to comply with spec (RP CAN use nonce, but when they do, we cannot drop it)
  • default authentication-enforcing and authorization implementations

MichaelKubovic avatar Nov 06 '19 16:11 MichaelKubovic

@MichaelKubovic, thanks for your mention.

As the original author of the implementation, I discarded the idea to submit it as a PR because I think it is out of the scope of this bundle. But is up to the @trikoder team to decide about it.

Currently I'm implementing the OIDC support as a different bundle that leverages this one to provide the oAuth2 server implementation.

If this PR is discarded, I could publish my current draft implementation, so you can collaborate if you want.

ajgarlag avatar Nov 07 '19 08:11 ajgarlag

@MichaelKubovic @ajgarlag Thank you for your continued involvement with bundle's development. We'll review this PR soon. :+1:

spideyfusion avatar Nov 29 '19 09:11 spideyfusion

Any updates on this?

jankulovski avatar Dec 19 '19 18:12 jankulovski

Any updates?

Tayfun74 avatar Dec 24 '19 08:12 Tayfun74

@jankulovski @Tayfun74 Sorry for no response. It is holiday season here and the team is a bit more in vacation mode. We should be back in full number in the next week and I am sure @spideyfusion will also find the time to provide feedback on this PR.

alenpokos avatar Jan 02 '20 09:01 alenpokos

@spideyfusion When do you have time to provide feedback?

Tayfun74 avatar Mar 04 '20 06:03 Tayfun74

Any updates on this PR?

Tayfun74 avatar Nov 27 '20 13:11 Tayfun74