trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

feat(deployments): expose native build server option in build settings

Open myftija opened this issue 1 month ago • 2 comments

Adds a build setting about using our build server for remote builds.

myftija avatar Nov 14 '25 19:11 myftija

⚠️ No Changeset found

Latest commit: 0002859b52e4021820688f1dfc738e8a4ea3f062

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 14 '25 19:11 changeset-bot[bot]

Walkthrough

This pull request adds a new "Use native build server" option to the build settings feature. The implementation spans two files: updating the build settings schema to include an optional boolean field, and extending the build settings form component to add a checkbox UI element with corresponding form state, validation, and submission handling for the new field.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • The schema addition is straightforward, but the route file contains multiple interconnected changes (UI component, form state, validation schema transformation, submission handling)
  • Key areas requiring careful attention:
    • Verify the string "on" to boolean transformation in the validation schema functions as intended
    • Confirm that useNativeBuildServer is properly propagated through the form submission to the action handler and service call
    • Ensure change detection logic correctly identifies when useNativeBuildServer toggles
    • Validate that error handling and helper text for the new field align with existing patterns in the form

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It lacks required sections from the template including Testing, Changelog, Screenshots, and the Checklist, providing only a minimal overview. Complete all required template sections: add Testing steps, a Changelog entry describing the change, any Screenshots, and complete the Checklist items.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: exposing a native build server option in build settings, which directly aligns with the changeset's primary objective.
✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch native-remote-builds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 14 '25 19:11 coderabbitai[bot]