trickster icon indicating copy to clipboard operation
trickster copied to clipboard

Published 20 hours ago • verified publisher icon trickstercache

Replaced GOARCH and GO_VER ldflags

Open jnichols-git opened this issue 2 years ago • 1 comments

GOARCH is now GOHOSTARCH; references in logging to GOARCH now refer instead to GOHOSTARCH. Runtime functionality that relies on runtime architecture is already using it, so no changes to packages that make decisions based on architecture. GOARCH was used for logging only.

GO_VER is removed; package runtime now has GoVersion which is set with other runtime variables in main. All references to applicationGoVersion now reference trickster.runtime.GoVersion.

Fixes #606

Signed-off-by: jakenichols2719 [email protected]

jnichols-git avatar Sep 14 '22 02:09 jnichols-git

The test being failed is regarding the example version print; since the test now pulls the go version on startup, rather than being passed on build, the field for goVersion is not empty. Looking into the best resolution for this.

jnichols-git avatar Sep 14 '22 03:09 jnichols-git

Pull Request Test Coverage Report for Build 3175437877

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.37%
Totals Coverage Status
Change from base Build 3011110302: 0.002%
Covered Lines: 16025
Relevant Lines: 16981
💛 - Coveralls

coveralls avatar Oct 03 '22 14:10 coveralls