Trinity-Bots icon indicating copy to clipboard operation
Trinity-Bots copied to clipboard

[TC] [AC] [Question/Feature] [Group/Spell/Core] Let dps warrior bots Sunder to

Open Vir27 opened this issue 1 year ago • 3 comments

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • [X] I understand that my issue may get closed without notice if I intentionally remove or skip any mandatory* field
  • [X] This is NOT a bug/crash report
  • [X] I've searched the bugtracker for similar questions/requests including closed ones

Description

Thank you for maintaining this game-making mod.

The Sunder Armor debuff can come from a warrior, a rogue's Expose Armor, a BM hunter worm. As far as I can tell, only protection warriors and worms will actually use it, and this seems like an unintended limitation on party composition (always have a war tank or else bring a BM hunter with a worm). Expose Armor is not very good for rogue's dps, so I don't suggest opening that there. Would it be possible to allow dps war bots (particularly arms, for my druthers) to use Sunder Armor?

If most people do not want them using this, it is already in the Manage Abilities list (just they don't think to use it when enabled) and could be disallowed by default. So it's no downside, except your much appreciated investment of time to make the tweak?

I am open to self-help and figure out the code with assistance from my fiancee's professional coding skills if I knew what to open. The gent who develops my favorite repack screenshot me bot_warrior_ai in what she identifies is Visual Studio. While I think giving more party compositions the ability to Sunder Armor is a good suggestion for NPCBots, I am open to work the tweak out at my own peril, if preferred.

Thank you for considering.

TrinityCore or AzerothCore

AzerothCore

Core rev. hash/commit

AzerothCore rev. 1ab2a7e0b644+ 2024-01-28 13:52:38 -0700 (npcbots_3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

Operating system

Win10

Vir27 avatar Mar 04 '24 04:03 Vir27

It's limited because Sunder Armor debuff from a different caster would override an existing one instead of stacking. At least that's how it worked at a moment that code was introduced. I'll need to re-check it on both cores before making a decision. However, if you're curious the check is at bot_warrior_ai.cpp lines 817-818

trickerer avatar Mar 04 '24 13:03 trickerer

Thank you. Could you help me know where to find that cpp? I believe I will open something in Visual Studio (and then show my fiancee for coding help), but I haven't found what to open.

The overriding won't be an issue for me personally because I am making my team composition purposefully.

Vir27 avatar Mar 04 '24 15:03 Vir27

Oh well. It's in /src/server/game/AI/NpcBots/

trickerer avatar Mar 05 '24 01:03 trickerer

Hey thanks so much, man!

Vir27 avatar Mar 14 '24 15:03 Vir27