Trinity-Bots icon indicating copy to clipboard operation
Trinity-Bots copied to clipboard

[AC] [Bug] Uneven BG Teams if Alliance

Open StraysFromPath opened this issue 1 year ago • 4 comments

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • [X] I understand that my issue may get closed without notice if I intentionally remove or skip any mandatory* field

Current behaviour

Join BG as alliance you have 2 less players for some reason.

Instead of 7/7 it's 6/8.

image

Expected behaviour

Even teams.

Crashlog

No response

Steps to reproduce the problem

No response

TrinityCore or AzerothCore

AzerothCore

Core rev. hash/commit

acore jan 1st

Operating system

win10 server

StraysFromPath avatar Jan 22 '24 23:01 StraysFromPath

It's a client bug. Client assumes team by bot's race and some bots have their race and faction mismatch

trickerer avatar Jan 23 '24 01:01 trickerer

It's a client bug. Client assumes team by bot's race and some bots have their race and faction mismatch

Thank you for the reply (and the module). It's amazing. I might have misread this.

It's not just client menu/display error, the teams actually have uneven numbers of players such as 5 on one side and 9 on the other instead of 7/7.

Out of 100+ BGs played on my server it is reported that about 30-40% of games it is alliance that is missing members.

Even if 4 human beings queue alliance it will end up 6v8 with 2 bots and 4 humans vs 8 bots.

But if 4 humans queue horde it can be 10v4.

StraysFromPath avatar Jan 23 '24 02:01 StraysFromPath

Ah, this must be a problem with more than 1 player in bg. When number of total bg participants reaches the maximum all remaining bots get cancelled, so if the number of real players is uneven between teams this situation may get preserved, +1/-1. It's hard for me to test reliably but I can try to add an additional check for team balance. It's supposed to work like this: when the first player tries to queue into bg <MAX_BG_PLAYERS - 1> number of bots is generated, max number for the opposing team and max number-1 for player's team. If a number of additional players join the bg and at the time when each bot tries to enter bg map there is a disbalance between teams and this additional bot would increase it this bot should be skipped and deleted. But additional players may still join the bg afterwards if they got an invitation.

trickerer avatar Jan 23 '24 02:01 trickerer

Can't confirm. Are you sure you actually have enough bots to fill all the rosters for your players?

Details

WSG. Default settings. NpcBot.WanderingBots.BG.TargetTeamPlayersCount.WS = 8

  • Join as group (2 members, Alliance), even teams: WoWScrnShot_032124_073356
  • Join individually (2 players, Alliance), A+1: WoWScrnShot_032124_073245

Works as expected in both cases

trickerer avatar Mar 21 '24 00:03 trickerer

Actually I think this is just a matter of players joining the BG as a group with bots in it. BG stat determines team based on bot's race, not its owner's team. This could easily lead to any kind of imbalance visually

trickerer avatar May 25 '24 03:05 trickerer