jest-serializer-path icon indicating copy to clipboard operation
jest-serializer-path copied to clipboard

Published 20 hours ago • verified publisher icon tribou

replace node_modules with <NODE_MODULES>

Open chrisblossom opened this issue 6 years ago • 2 comments

Because node_modules are not consistent I found some issues where my snapshots were failing. This makes all node_modules under a single <NODE_MODULES> tag.

chrisblossom avatar May 15 '18 23:05 chrisblossom

Coverage Status

Coverage remained the same at 100.0% when pulling 68d49b60e7d7baaef7864e6177a5ad992b5473cb on chrisblossom:handle-node-modules into 6ab71115217e304422d0e294b009d1f17fdfe6dc on tribou:master.

coveralls avatar May 15 '18 23:05 coveralls

I'm not 100% sure this should be merged because it might have other side effects. Wonder if there is a way we can make this opt-in?

Edit: Definitely hold off on merging this. It will break any text with node_modules and I think a better solution will need to be thought out completely / this might need to be dropped entirely.

chrisblossom avatar May 16 '18 05:05 chrisblossom