trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

Published 20 hours ago • verified publisher icon trezor

BTC as a currency pair for all coins

Open Hannsek opened this issue 2 years ago • 2 comments

Some users may find useful to have BTC as a currency pair for all coins.

proposed changes

  • [ ] Put BTC ~~and ETH~~ as an option in the drop down menu in Settings/Application/Localization/Fiat currency
  • [ ] rename the Fiat currency field to Unit as there are other assets like Gold, Silver, XDR

-> BTC will be the currency pair as e.g. USD, EUR, … so at all places in suite, where USD (EUR) is now, BTC will replace it (except BTC accounts)

examples

image image

Hannsek avatar Aug 05 '22 07:08 Hannsek

Attempted to solve via #6547

Testable: https://suite.corp.sldev.cz/suite-web/sime/add-btc-currency/web/

sime avatar Nov 02 '22 12:11 sime

  1. Wallet switcher
    1. Replace the fiat values with values in BTC/sats according to the user's selection in the settings.
  2. Dashboard
    1. Portfolio value: Replace the fiat value with values in BTC/sat according to the user's selection in the settings.
    2. Graph Y-axis: Use the scale in BTC similar to how it is used in BTC accounts.
    3. Accounts list (in the left side menu)
      1. Bitcoin: Simply do not display the fiat value.
      2. Altcoins (incl. Tokens & Staking): Instead of the fiat value, display BTC/sat according to the user's settings. Since it likely won't fit within the current width, please move the BTC/sat value to a new row to allow it full width. However, retain the current arrangement for fiat values.
    4. Assets (both list and cards view)
      1. Bitcoin
        1. Balance: Display only the BTC/sat value in place of the current fiat value, as it is a larger figure. Please do not repeat the BTC value below; leave that bottom position empty.
        2. Price: Display "1 BTC = 1 BTC"
        3. 7D change: Display nothing; leave the position empty.
      2. Altcoins
        1. Balance: Replace the fiat values with values in BTC/sat according to the user's selection in the settings.
        2. Price: Display the calculated price of the Altcoin in BTC/sat value.
        3. 7D change: Calculate if from the Altcoin/BTC change please.
  3. Settings
    1. Label: Please rename 'Fiat Currency' to 'Currency'.
    2. Select menu: Please add 'BTC' to the top of the select menu and add a divider below it
  4. BTC Account, Send, Tx detail
    1. Main header: Instead of the main fiat value, show value in BTC/sat according to the user's selection in the settings.
      1. Instead of the original smaller BTC value above the main value, show nothing. Leave there just the BTC logo. (warning: for BTC accounts only, for altcoins, the altcoin value will be shown here)
    2. Minimized header: Display just the BTC value, hide the fiat value (warning: for BTC accounts only, for altcoins, BTC/sat value will be shown in this place)
    3. 'Incoming' and 'Outgoing' tabs: Remove fiat values (warning: for BTC accounts only, for altcoins, BTC/sat value will be shown in this place)
    4. Trade frame: Keep Price and 7d change as it is, for Buy and Sell, the fiat value of BTC remains relevant.
    5. Transactions history:
      1. Daily sum: Display in BTC/sat
      2. Transaction fiat value: Do not display
    6. Transaction detail (modal): Hide fiat values and their dates (warning: for BTC accounts only, for altcoins, BTC/sat value will be shown in this place)
    7. Send form:
      1. Remove the fiat input field, use full width for amount in BTC
      2. Fee: Remove the fee in fiat
      3. Summary: Display fee in BTC/sat (the 'Incl. fee' field)
      4. Coin control: Hide the fiat value of UTXOs (warning: for BTC accounts only, for altcoins, BTC/sat value will be shown in this place)
      5. Send modal: Hide fiat values (warning: for BTC accounts only, for altcoins, BTC/sat value will be shown in this place)
  5. ETH Account, Send, Tx detail (other altcoins similarly please)
    1. Main header: Replace the fiat value with value in BTC/sats according to the user's selection in the settings.
    2. Minimized header: Replace the fiat value with value in BTC/sats according to the user's selection in the settings.
    3. 'Incoming' and 'Outgoing' tabs: Replace the fiat values with values in BTC/sats according to the user's selection in the settings.
    4. Trade frame:
      1. Price: Display the calculated price of the Altcoin in BTC/sat value.
      2. 7D change: Calculate if from the Altcoin/BTC change please.
    5. Transactions history:
      1. Daily sum: Display in BTC/sat
      2. Transaction fiat value: Display in BTC/sat
    6. Transaction detail (modal): Replace the fiat values with values in BTC/sat according to the user's selection in the settings.
    7. Tokens list: Replace the fiat values with values in BTC/sat
    8. Send form:
      1. Remove the fiat input field, use full width for amount in ETH
      2. Maximum fee: Replace the fiat value with value in BTC/sat.
      3. Summary: Display fee in BTC/sat (the 'Incl. fee' field)
      4. Send modal: Replace the fiat values with values in BTC/sat according to the user's selection in the settings.
  6. BTC Testnet
    1. No specific changes needed, shows nicely how BTC would look without fiat values.
  7. BTC Trade - Buy
    1. Stays mostly the same. 'Buy' will still be for fiat, as long as we maintain separate flows for 'Buy' and 'Exchange'.
    2. In the "Receive step" of the buying flow, please remove the fiat values shown at the account and address.
  8. ETH Trade - Buy (other altcoins similarly)
    1. Stays mostly the same. 'Buy' will still be for fiat, as long as we maintain separate flows for 'Buy' and 'Exchange'.
    2. In the "Receive step" of the buying flow, replace the fiat value in the 'Receive account' field by BTC/sat. (note: make sure to keep the 'Spend' field in fiat, as that is really what the user will spend to Buy the ETH for.
  9. BTC Trade - Sell
    1. Stays the same. 'Sell' will still be for fiat, as long as we maintain separate flows for 'Sell' and 'Exchange'.
    2. In the 'Trade transactions' (history), keep fiat shown in 'Sell' and 'Buy' transactions, as those are really done against fiat.
    3. Resist the urge to insert memes.
  10. ETH Trade - Sell
    1. Stays mostly the same. 'Sell' will still be for fiat, as long as we maintain separate flows for 'Sell' and 'Exchange'.
    2. When setting the Maximum fee, replace the fiat value by value in BTC/sat.
  11. BTC Trade - Exchange
    1. Trade form
      1. Remove the fiat input in the 'From' part of the Exchange form, use full width for BTC
      2. Balance: Remove the fiat value
      3. Fee: Remove the fiat value
    2. Comparator: In the 'All fees included' fee estimate, remove the fiat value please (don't forget to remove also the adjacent brackets and space please)
    3. Receive address: At the altcoin receiving account, replace the fiat value by value in BTC/sat. (also in the dropdown menu)
  12. ETH Trade - Exchange
    1. Trade form
      1. Remove the fiat input in the 'From' part of the Exchange form, use full width for the selected coin (ETH in this case)
      2. Balance: Replace the fiat value with value in BTC/sat.
      3. Fee: Replace the fiat value with value in BTC/sat.
    2. Comparator: In the 'All fees included' fee estimate, replace the fiat value with value in BTC/sat.
    3. Receive address (also in the dropdown menu):
      1. If receiving BTC, remove fiat value (don't forget to remove the divider dot as well)
      2. If receiving another altcoin, replace the fiat value with value in BTC/sat.
  13. BTC Trade - DCA
    1. Let's keep it as it is, it's still Dollar Cost Averaging (or rather Fiat Cost Averaging), so let's not get too wild here removing fiat.
  14. BTC Trade - P2P
    1. Let's keep it as it is, it's still Buy for fiat money.
  15. ETH Staking
    1. Let's keep it as it is, messing with BTC within ETH staking might just bring confusion and inconsistency.

Hermez-cz avatar May 02 '24 12:05 Hermez-cz