trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

Old transactions are occasionally marked as new in Suite Notifications

Open bosomt opened this issue 5 years ago • 22 comments

Info:

  • OS: Windows 10
  • Wallet Version: app, commit 99959260d5639480dfb11e53a4f2ab1d789b0e7b
  • Firmware Version:TT, model 2.3.4, revision

Describe the bug Old transactions are occasionally marked as new in Suite Notifications It happened to me 3 times today. See screenshots. Happened to ETH and BTC coins. Looks like that new transaction arriving or confirmation to idle suite triggers event that all transactions are marked as new and there are hundreds of new Activities. This drains computer resources completely /im not able to start browser or snipping tool/ This happened even after Suite data was cleared via Suite button.

Steps to reproduce: I was not able to way to reproduce it. It just happens. I tried to reproduce it via web version. Nothing. As soon I have more information I will provide them.

Of course I can provide logs or any local data if needed.

Screenshots: image image

bosomt avatar Oct 15 '20 11:10 bosomt

I have only BTC enabled and tXRP transactions appeared ;)

image

bosomt avatar Oct 15 '20 12:10 bosomt

@bosomt is it still an issue on current develop? i gotta feeling that this may be solved by recent websocket fixes

szymonlesisz avatar Oct 26 '20 14:10 szymonlesisz

@szymonlesisz not anymore, I think we can close it and move it to Merged. If it won't happen I will move it to approved section

bosomt avatar Oct 26 '20 14:10 bosomt

QA OK

I have not experienced this anymore with latest apps or web versions

Nixos + Firefox 82.0 (64-bit) Suite web commit 53e0e15 Device model One fw 1.9.3 commit 0x0d5f00668fb3d1c093ff3c879311a91d3a7175c8,

bosomt avatar Nov 04 '20 09:11 bosomt

issue is back in latest dev master. Transactions appeared after I added new wallet via passphrase. Transaction list looks ok and transactions in notifications are linked to transaction in list with correct confirm time.

Firefox 82 + Nixos Suite web dev master commit b98f0b3a9dd168b13496127f4606b32532490401 Device model T fw 2.3.2 commit 63ebb8ccb

image

bosomt avatar Nov 19 '20 14:11 bosomt

I still have wallet opened and new notifications /with same transactions/ are still incoming every few minues if you need to collect/troubleshoot anything in Firefox

bosomt avatar Nov 19 '20 14:11 bosomt

still broken

image

image

Info:

  • Suite version: web 21.1.0 (e593c0e91fa1421c5ccfcdd75d51861382e91acc)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model One 1.9.4 regular

bosomt avatar Jan 13 '21 19:01 bosomt

Still happening in 21.3.1

Info:

  • Suite version: web 21.3.1 (1dbc5b720515c39a47f1dc58391dbebf1d766394)
  • Browser: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.3.5 regular

image(3) image(2)

bosomt avatar Mar 10 '21 11:03 bosomt

Still happening in 21.5.1 https://github.com/trezor/trezor-suite/commit/4d09d88476dab2e6b2fbfb833b749e9ac62251c2

bosomt avatar May 11 '21 14:05 bosomt

@bosomt has this happened to you recently ?

alex-jerechinsky avatar Sep 09 '21 12:09 alex-jerechinsky

@alex-jerechinsky yes it did :) even during last 21.9.1 release testing BUT only this two transactions to account 10 :) 👻

bosomt avatar Sep 09 '21 12:09 bosomt

Yap still happening :)

obrazek

trezor-suite-log-1631608260788.txt

Info:

  • Suite version: desktop 21.9.2 (cc85c69e3d6556e673c4d30f39953179f690b663)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_5_2) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.9.2 Chrome/89.0.4389.69 Electron/12.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model T 2.4.2 regular

bosomt avatar Sep 14 '21 09:09 bosomt

@bosomt could you please report if you still have this problem after releasing #4418?

If yes, bug must be somewhere in analyzeTransactions method or its params in transactionUtils.ts.

tomasklim avatar Nov 02 '21 14:11 tomasklim

@tomasklim I was never able to replicate this issue :) As soon this problem re-appears we will report it.

bosomt avatar Nov 02 '21 20:11 bosomt

QA NOK

so i was able to replicate issue, after some time and reconnection to internet one transaction was marked as new. But it's nothing compared to previous states when i used to have 100+ new transactions :)

obrazek

ypub6XRiqb2wR5dXP7wAQgzbVoLmd23AjaHVVX3SbLoeCtSc7MtWoZXuzxYDPEwTrjckM5dMbJFH8hqqK1oX5dUDfcB8kEDVPGDDLALq9mN5GMD

Info:

  • Suite version: desktop 21.11.0 (4a56ae794159091a4f2c4de847d237a47657dc1c)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.11.0 Chrome/93.0.4577.58 Electron/14.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model T 2.4.3 regular

bosomt avatar Nov 04 '21 17:11 bosomt

QA NOK

obrazek

Info:

  • Suite version: desktop 21.11.0 (4a56ae794159091a4f2c4de847d237a47657dc1c)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.11.0 Chrome/93.0.4577.58 Electron/14.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model T 2.4.3 regular

bosomt avatar Nov 05 '21 07:11 bosomt

So far, I've not experienced this problem. Do you have experience with this? @matejkriz

tomasklim avatar Nov 11 '21 13:11 tomasklim

QA NOK

problem with just this one transaction

obrazek

Info:

  • Suite version: desktop 21.12.2 (8cedeed1d1da121ab6b3dff4cb6365b9030634a2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/21.12.2 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model T 2.4.3 regular

bosomt avatar Dec 09 '21 13:12 bosomt

Another appearance today. Probably triggered by electrs or by Tor

hynek-jina avatar Feb 16 '22 14:02 hynek-jina

QA NOK

issue is still present app, tor off, vpn off, i just got 100+ notifications about new confirmed transactions

https://user-images.githubusercontent.com/31506317/167444798-f7c97c82-affb-4331-bc29-448e1bc1de6f.mov

Info:

  • Suite version: desktop 22.5.1 (06b93c51d07e8dfbd153c3e1569911884caf97a2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.5.1 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model 1 1.11.1 regular (revision 85a26d2c9593bcdf858c2d718d79951ca927a0c3)
  • Transport: bridge 2.0.31

bosomt avatar May 09 '22 15:05 bosomt

QA NOK

image

Info:

  • Suite version: desktop 22.9.0 (4d282475dccf0c52a0094e9b024fce5ad7c54e53)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.9.0 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model 1 1.11.2 Universal (revision 0d87b55ba4fed7eecc72bf2a94ee473830b095e9)
  • Transport: bridge 2.0.32

bosomt avatar Aug 11 '22 11:08 bosomt

it happened to our new testing passphrase now

image

Info:

  • Suite version: desktop 22.11.0 (7e7aae527cb912b2321e8ee671b6ba257b9b7289)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.11.0 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: model 1 1.11.2 Universal (revision 0d87b55ba4fed7eecc72bf2a94ee473830b095e9)
  • Transport: bridge 2.0.32

bosomt avatar Oct 13 '22 10:10 bosomt

QA NOK

still happening on all seed standard passphrase

Info:

  • Suite version: desktop 23.2.2 (00fe136fa75bc04628abf858e09223170b5cf188)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.2.2 Chrome/104.0.5112.124 Electron/20.3.12 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: model T 2.5.3 Bitcoin-only (revision 2f03ace311584988d5aeab58fd1acf24ef54711a)
  • Transport: BridgeTransport 2.0.32

bosomt avatar Feb 26 '23 02:02 bosomt

still happening on testing passphrase in latest 23.5.1 version

image

bosomt avatar May 15 '23 07:05 bosomt

@bosomt is this still valid please? :)

MiroslavProchazka avatar Mar 06 '24 15:03 MiroslavProchazka

@MiroslavProchazka havent seen it for some time gimme week, i will keep this issue in my mind and i will check notifications from time to time ;)

bosomt avatar Mar 06 '24 16:03 bosomt

QA OK

looks like we got rid of it finally after few years 🎉 if it happens again i will reopen :))))

Info:

  • Suite version: desktop 24.3.1 (e1bbd6e83b8d33b64dd562a137b279c66c902350)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.3.1 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2B1 2.7.0 regular (revision 45e8a842a31e62a6d43d7f6ccac62a45e1198ef0)
  • Transport: BridgeTransport 2.0.33

bosomt avatar Mar 08 '24 04:03 bosomt