trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

fix(suite): routes for tokens

Open enjojoy opened this issue 1 year ago • 9 comments

Description

  • Introduced nested routing in Tokens section. Now the search is not being re-rendered when changing tabs. Tho in the future it will be better to update routing utils functions to support nested routing by design.
  • Refactored some legacy styling.
  • Renamed Coins to My tokens

Related Issue

Resolve https://github.com/trezor/trezor-suite/issues/13142 https://github.com/trezor/trezor-suite/issues/14985

Screenshots:

https://github.com/user-attachments/assets/ccd568c1-1a7e-469c-b82c-3436064864ac

enjojoy avatar Oct 18 '24 15:10 enjojoy

Please also get rid of accounts/tokens/coins#... path. This path should be on accounts/tokens#... By that we will get rid of that nonsense coins in tokens 😀

So just const tokensRoutes = ['wallet-tokens', 'wallet-tokens-hidden'];

tomasklim avatar Oct 18 '24 21:10 tomasklim

@trezor/qa Please test both web and desktop app

enjojoy avatar Oct 21 '24 10:10 enjojoy

@adderpositive Martin, I think that this routing method and NavigationItem styling can be useful in coinmarket, as you also have a similar design in Trading section, please consider implementing

enjojoy avatar Oct 21 '24 11:10 enjojoy

Small visual bug - search in the middle. image

adderpositive avatar Oct 21 '24 16:10 adderpositive

image Can you please make a clickable whole circle? It is more user-friendly.

adderpositive avatar Oct 21 '24 17:10 adderpositive

@adderpositive Martin, I think that this routing method and NavigationItem styling can be useful in coinmarket, as you also have a similar design in Trading section, please consider implementing

In the trade section, NavigationItem is used with some small overrides for a responsive design. Routing method should be consider. I like it.

adderpositive avatar Oct 21 '24 17:10 adderpositive

Small visual bug - search in the middle. image

Thank you, didn't test it with debug on

enjojoy avatar Oct 22 '24 06:10 enjojoy

image Can you please make a clickable whole circle? It is more user-friendly.

yes, good point

enjojoy avatar Oct 22 '24 06:10 enjojoy

@adderpositive Martin, I think that this routing method and NavigationItem styling can be useful in coinmarket, as you also have a similar design in Trading section, please consider implementing

@adderpositive primarily talking of routing, it's more smooth without unnecessary page reloading

enjojoy avatar Oct 22 '24 07:10 enjojoy

/rebase

tomasklim avatar Oct 29 '24 00:10 tomasklim

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11565047661

github-actions[bot] avatar Oct 29 '24 00:10 github-actions[bot]

Rebasing failed, please rebase manually.

github-actions[bot] avatar Oct 29 '24 00:10 github-actions[bot]