trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

feat(suite-native): new device switcher

Open vytick opened this issue 9 months ago • 2 comments

Update wallet switcher visual to show view only devices correctly

  • [x] Generic device icon changed to model-specific
  • [x] Show current device connection state
  • [x] Show/hide device selector on button tap
  • [x] Show all devices including connection state (view only)
  • [x] Make device selector slide out/in animated
  • [x] Show all wallets for current device
  • [x] Hide Open passphrase button behind feature flag and make it disabled during discovery
  • [x] New connected state for View only settings harmonised with new design
  • [x] New visual for current device/wallet when closed manager

These two tasks will be dealt with in following PR so this one is not even bigger

  • Show wallet fiat amount
  • Scrolling wallets to fit size

Related Issue

Part of #11892

Screenshots:

https://github.com/trezor/trezor-suite/assets/2011829/b7858d48-e537-48d2-882b-e3a84c280a1d

vytick avatar May 07 '24 08:05 vytick

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 07 '24 08:05 socket-security[bot]

@SocketSecurity ignore-all

vytick avatar May 07 '24 09:05 vytick

RESOLVED ~~I just spotted missing padding below Connect another device button in case of multiple devices~~

image

matejkriz avatar May 15 '24 10:05 matejkriz

@matejkriz Good catch with layout glitch! fixed in a5016a6d9c

vytick avatar May 15 '24 12:05 vytick

/rebase

vytick avatar May 15 '24 14:05 vytick

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/9097132563

github-actions[bot] avatar May 15 '24 14:05 github-actions[bot]