trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

fix: handle estimated fee error

Open enjojoy opened this issue 11 months ago • 5 comments

The error coming from geth and returned the value of the error with a notification.

I have a couple of questions as I'm not sure what the expected outcome is, I'd be happy to discuss it and get some help.

  • Should I handle every incoming error differently and provide a differently interpreted message or returning the initial error value is sufficient?
  • I'm not sure how to test in this case, I couldn't seem to find any examples on how/where the function is used.

Closes #3283

enjojoy avatar Mar 20 '24 19:03 enjojoy

related to https://github.com/trezor/trezor-suite/issues/3283

tomasklim avatar Apr 03 '24 14:04 tomasklim

And also please rebase, there were bigger changes to this file.

I believe it's up to date with the develop branch, I tried to rebase it and got no conflicts whatsoever, could you please check?

enjojoy avatar May 07 '24 23:05 enjojoy

And also please rebase, there were bigger changes to this file.

I believe it's up to date with the develop branch, I tried to rebase it and got no conflicts whatsoever, could you please check?

It seems that there are some conflicts in packages/suite/src/actions/wallet/send/sendFormEthereumActions.ts

MiroslavProchazka avatar May 08 '24 07:05 MiroslavProchazka

Also please reword your commits so they are like fix(suite):..., feat(suite): ... etc.

AdamSchinzel avatar May 09 '24 10:05 AdamSchinzel

Screenshot 2024-05-10 at 21 45 17 Screenshot 2024-05-10 at 21 54 18

tomasklim avatar May 10 '24 19:05 tomasklim