trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

Published 20 hours ago • verified publisher icon trezor

Empower/Invity/ input form misaligned

Open MiroslavProchazka opened this issue 1 year ago • 7 comments

DEX Flow (ETH-USDC ERC20) - step3 - Vlastní odchylka input is misaligned

image

MiroslavProchazka avatar Jan 31 '24 07:01 MiroslavProchazka

Screenshot 2024-03-07 at 18 31 52 Any advice with how this should behave? I got rid of the bottom padding - the padding is there for making space for the validation message. @MiroslavProchazka

zuzjes avatar Mar 07 '24 17:03 zuzjes

Screenshot 2024-03-07 at 18 33 14 This is how it look without the validation error message..

zuzjes avatar Mar 07 '24 17:03 zuzjes

Hmm, this one is tricky. @marek-andrsk do you have some thoughts on this? Personally I would just place the error message directly below the cell (with custom number) and center it, but as in the previous issue, I would rather leave this design decision up to you (and Marek).

MiroslavProchazka avatar Mar 07 '24 19:03 MiroslavProchazka

Or the input could show under the select of values, so it don't size down when I click on custom, it's a bit weird as well. So we would not have to think about what to do with the validation. @MiroslavProchazka

zuzjes avatar Mar 08 '24 08:03 zuzjes

Yep, could be as well. Still I would rather wait for confirmation from @marek-andrsk.

MiroslavProchazka avatar Mar 08 '24 08:03 MiroslavProchazka

@zuzjes can you please move the error message directly bellow the fee picker element and align to the left so that there's enough space for longer text

marek-andrsk avatar Mar 08 '24 13:03 marek-andrsk

So input for custom fee will stay where it is and somehow move just the error message bellow the whole element, will try my best @marek-andrsk

zuzjes avatar Mar 08 '24 13:03 zuzjes

@marek-andrsk is this OK by you?

Screenshot 2024-03-19 at 11 38 57

zuzjes avatar Mar 19 '24 10:03 zuzjes

@zuzjes that's great, thank you

marek-andrsk avatar Mar 19 '24 10:03 marek-andrsk

Resolved by https://github.com/trezor/trezor-suite/pull/11357

MiroslavProchazka avatar Apr 28 '24 05:04 MiroslavProchazka

QA OK

please consider follow up issue for entering hex number ;) @zuzjes

QA NOK

Image

QA OK

Image Image

Info:

  • Suite version: desktop 24.5.1 (f64356923761ba0d81299f5e165177a742b6fb78)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.5.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2B1 2.7.0 regular (revision 45e8a842a31e62a6d43d7f6ccac62a45e1198ef0)
  • Transport: BridgeTransport 2.0.33

bosomt avatar May 06 '24 07:05 bosomt

cc @FreeWall & @marek-andrsk. image

MiroslavProchazka avatar May 06 '24 08:05 MiroslavProchazka