trezor-suite icon indicating copy to clipboard operation
trezor-suite copied to clipboard

Published 20 hours ago • verified publisher icon trezor

Empower/Invity/Comparator - info-notes are off

Open MiroslavProchazka opened this issue 1 year ago • 10 comments

image

MiroslavProchazka avatar Jan 30 '24 14:01 MiroslavProchazka

What are info notes? It would be really good to have some drawings in the picture so its clear.

peter-sanderson avatar Jan 30 '24 16:01 peter-sanderson

Hey @peter-sanderson , I'm trying to gather more info. For now please delete this text as it seems it should be not part of the production version. Thanks! image

MiroslavProchazka avatar Feb 01 '24 08:02 MiroslavProchazka

The wrong text "Long message used to test the feature" is not fetching from a codebase, but from somewhere in Invity source. Can you please investigate?

cc @IvaFingerova @FreeWall

MiroslavProchazka avatar Feb 02 '24 15:02 MiroslavProchazka

Info notes are the yellow Tags "Test tag" - we need to adjust the padding around and center them to proper position. The text to which the arrow is directing is correct, no need to fix it.

MiroslavProchazka avatar Feb 06 '24 15:02 MiroslavProchazka

@MiroslavProchazka Should we check and eventually use Badge component from Storybook?

LukasRada avatar Feb 26 '24 14:02 LukasRada

cc @jvaclavik , can you help Luky please? :)

MiroslavProchazka avatar Feb 26 '24 14:02 MiroslavProchazka

@jvaclavik I am working on this task, would you alight the badge to center, or remove the padding from left ?

zuzjes avatar Feb 27 '24 10:02 zuzjes

@MiroslavProchazka please some advice, help?

zuzjes avatar Mar 07 '24 16:03 zuzjes

Sorry, I missed this one. I would rather ask @marek-andrsk what should be the desired outcome as this issue was originally created by @IvaFingerova. So I would leave this completely in your hands :)

MiroslavProchazka avatar Mar 07 '24 19:03 MiroslavProchazka

@zuzjes align to the left please, i.e. remove the padding as you suggest :)

marek-andrsk avatar Mar 08 '24 13:03 marek-andrsk

Resolved by https://github.com/trezor/trezor-suite/pull/11357

MiroslavProchazka avatar Apr 28 '24 05:04 MiroslavProchazka

QA OK

Info:

  • Suite version: desktop 24.5.1 (f64356923761ba0d81299f5e165177a742b6fb78)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.5.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T2T1 2.7.0 regular (revision 45e8a842a31e62a6d43d7f6ccac62a45e1198ef0)
  • Transport: BridgeTransport 2.0.32

STew790 avatar May 02 '24 16:05 STew790