trezor-firmware icon indicating copy to clipboard operation
trezor-firmware copied to clipboard

Published 20 hours ago • verified publisher icon trezor

Rust UI: device setup

Open mmilata opened this issue 3 years ago • 6 comments

Part of #2298. Master diff: https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/2716418986/artifacts/master_diff/index.html

TODO:

  • [x] fix spacing in the success dialog
  • [ ] ~~add f"Write down these {len(share_words)} words in the exact order:" dialog, teach tests to detect UI2~~

Pics:

create1 createsucc createbackup bacupwarning seed1 seed2 seed3 seedcheck seedcheckfail seedfinish1 seedfinish2 shamir1 shamir2 checklist1 checklist2 checklist3 shamir3info sdprotect

mmilata avatar Jul 13 '22 15:07 mmilata

what are these about? image i'm guessing spacing?

matejcik avatar Jul 14 '22 11:07 matejcik

Cardano tests seem completely broken

matejcik avatar Jul 14 '22 11:07 matejcik

what are these about?

The text is 1px to one side due to different component used.

mmilata avatar Jul 14 '22 11:07 mmilata

Cardano is broken because the last batch of Cardano changes started using a layout that's not implemented yet in UI2. The fixtures weren't updated when it was merged because it is a manual job in CI.

cardano

mmilata avatar Jul 15 '22 10:07 mmilata

Fixed the cardano tests in ef218aa and improved the success/modal spacing in aa3481b.

Master diff: https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/2728590011/artifacts/master_diff/index.html

a0a1

b0b1

c0c1

d0d1

mmilata avatar Jul 15 '22 18:07 mmilata

what is missing for the recovery tests? we do have the keyboards.

matejcik avatar Jul 20 '22 09:07 matejcik

Rebased to master. Recovery is mostly missing these:

rec2 rec0 rec1

I wanted to do it separately because we don't use Rust homescreens yet. This PR is still missing the correct checklist theme, working on it.

mmilata avatar Aug 21 '22 18:08 mmilata

Checklist theme updated in 160c916 (UI diff)

checkA checkB checkC

The normal font is 18px tall but the bold one 16px. I wonder if it's better to use normal font for the current item as well. Otherwise this PR is ready.

mmilata avatar Aug 23 '22 16:08 mmilata

What was suggested in previous post. Maybe @sime can help me?

checkA checkB checkC

mmilata avatar Aug 23 '22 18:08 mmilata

@Hannsek can you tackle this?

sime avatar Aug 24 '22 07:08 sime

@mmilata Is there any reason why we don't use 18px font on every row?

Hannsek avatar Aug 24 '22 16:08 Hannsek

@Hannsek we only have following fonts on device:

  • normal: TTHoves Regular 18px
  • medium: TTHoves Medium 20px
  • bold: TTHoves Bold 16px
  • monospace: RobotMono Regular 20px

It's not easy to add more due to flash memory constraints.

mmilata avatar Aug 24 '22 20:08 mmilata

@mmilata Can we do something like this? To make not-current actions less visible… image

Hannsek avatar Aug 25 '22 06:08 Hannsek

~Sure:~ checkA checkB checkC

mmilata avatar Aug 25 '22 11:08 mmilata

Sorry, used the bold font by mistake in the previous comment checkA checkB checkC

mmilata avatar Aug 25 '22 11:08 mmilata

Added recovery layouts. Again I mostly copied the old design so feel free to request changes or point me to figma.

home0 home1 home2 number_select succ1 invalid remain1 remain2

mmilata avatar Aug 31 '22 12:08 mmilata

[master diff]

mmilata avatar Aug 31 '22 16:08 mmilata