react-scroll-manager icon indicating copy to clipboard operation
react-scroll-manager copied to clipboard

Published 20 hours ago • verified publisher icon trevorr

Does not appear to work with React Router v5.

Open BBaysinger opened this issue 5 years ago • 6 comments

I tried several configurations. No errors, but basically functions as if there was no scroll restoration at all.

I had some luck reverting to v4, but still wasn't totally working. I can come back and fill in more details as time allows.

BBaysinger avatar Nov 09 '19 03:11 BBaysinger

I haven't had a chance yet to try it with RRv5. I'll try to get to it in a few weeks, as I plan to start a new React project then.

trevorr avatar Nov 11 '19 21:11 trevorr

Ok, thank you.

BBaysinger avatar Nov 12 '19 06:11 BBaysinger

any updates on this?

kelly-tock avatar Aug 20 '20 14:08 kelly-tock

Sorry, none yet. I have been using RRv5 in some new projects, but none have needed scroll restoration yet. If someone can point me to a repository that demonstrates the problem, I'm happy to take a look. However, I don't have time at the moment to try to reproduce the issue from scratch.

trevorr avatar Aug 21 '20 15:08 trevorr

I've been able to reproduce this in a RRv5 project. The WindowScroller is not updated because of the RRv5 change to use the new context API for passing location: https://reacttraining.com/blog/react-router-v5/. I think I'll need to make a new major version for RRv5. It will also be an opportunity to move to hooks and Typescript.

trevorr avatar Nov 06 '20 05:11 trevorr

I am using react-router 5.1.2, and it works like a charm!

BenjaminVanRyseghem avatar Mar 10 '21 01:03 BenjaminVanRyseghem