ggpattern icon indicating copy to clipboard operation
ggpattern copied to clipboard

New `pattern_linewidth` aesthetic?

Open trevorld opened this issue 3 years ago • 2 comments

  • {ggplot2} is renaming the size aesthetic to linewidth when referring to line widths
  • Should {ggpattern} rename the pattern_size aesthetic to pattern_linewidth when referring to pattern line widths to match the above change?
  • Obviously keep support for pattern_size for backwards compatibility...

trevorld avatar Jun 17 '22 02:06 trevorld

Perhaps easier if we first support new linewidth parameter in {gridpattern}: https://github.com/trevorld/gridpattern/issues/57

trevorld avatar Jun 17 '22 02:06 trevorld

  • Development version of {gridpattern} can now handle either using pattern_linewidth or pattern_size (and makes both available to custom patterns).
  • Looking at what {ggplot2} did it seems keeping backwards compatibility for pattern_size would be a "non-trivial" enterprise and currently there aren't any known patterns that need both a pattern_size and pattern_linewidth aesthetic... Leaning towards not adding a new pattern_linewidth aesthetic for now but would be open to backwards-compatible pull requests that implement this...

trevorld avatar Jun 20 '22 05:06 trevorld