Trevor Vaughan

Results 117 comments of Trevor Vaughan

@mathieu-aubin Thanks for pinpointing this, should be corrected.

@mathieu-aubin If possible, I'd like to get this through as functional and then have separate work for "pretty". This PR doesn't address all of the ideas in the full comment...

@abitrolly Rebased. Not interested in re-breaking trivial whitespace updates. Will happily add tests for detecting that a SRPM was output if you can point me at the tests that show...

Test failures appear unrelated to this change.

I can rebase this again. I didn't realize there was still interest in it to be honest.

@ryysud and @jordansissel Rebased and removed vestiges of travis material.

@jordansissel No problem. Just update the thread if you find any issues.

> My initial feedback is that I wonder if this should be a separate output type? Like --output-type srpm ? I hadn't thought about users that wouldn't expect two RPMs...

I'd like to link this back over to https://github.com/usnistgov/OSCAL/issues/216#issuecomment-425208258 because my concerns are the same.

Per the comment from @noahdesu adding the following to `~/.vagrant.d/Vagrantfile` on Fedora 30 fixed the issue for me: ``` Vagrant.configure('2') do |config| config.vm.provider :libvirt do |v| v.qemu_use_session = false end...