trettberg

> You are already assuming that the user will call a function to get FIR coefficients, right? No. It is merely assumed that filter coefficients are needed for FIR filtering....

> I think we actually should suggest a certain usage, and this usage should include an explicit filtering step. > > Initially, I thought we could just use generic filter...

> And the question about the API would be if we should have the impulse-reponse-generating function as a user-callable function of just as an implementation detail (or not at all)....

I've tried to pick up the open ends: * Coefficient generation is done internally in `_wfs_prefilter_fir`. The user calls the API function `wfs_25d_fir_prefilter`, see example below. * Since the filter...

> I was wondering, if it's worth shifting the call of `wfs_25d_fir_prefilter` to `drivingfunction.wfs_25d_*.` We could plug a filter function into `drivingfunction.driving_signals()`. However, I'd wait until we have more a...

Two observations: * The contour has a gap. * The region of active sources is not symmetric. (Easier to see with few speakers, 16 or so).

> If I remember correctly the orientation vector is parallel to the line in this case and it is implemented for WFS in Matlab. Unfortunately [it does not work that...

Exactly. As a result, we cannot use arbitrary line sources as secondary sources (Green's functions). The line source's "orientation" should rather be a separate "up vector".

Alternatively we could get rid of `sfs.util.normal_vector()`. It seems it is used only in `sfs.util.rotation_matrix()`.

Currently we use only quadrature grids: The grid determines ISHT matrix `Y`. The SHT matrix is then given by `Y^H D`, where diagonal matrix `D` contains the quadrature weights. This...