Kailey Lampert
Kailey Lampert
Added some todos inline for future fixes. To resolve before marking this PR ready: (#15) Cookie isn't saving the right data. Need to see if problem is a regression from...
Either a different hook (back compat risk), or better regex. I note primarily because Twenty Twenty runs some code there that makes our regex not match. But it's unclear to...
Addresses #1 Filters the conditional that controls when a TOC is added, allowing plugin customization.
resolves #4 This PR removes `h4` tags from the default TOC generation, as they were not added correctly. Now, `h3` is used by default and is filterable, allowing `h4` tags...
Introduced in WP5.8 https://make.wordpress.org/core/2021/06/29/introducing-update-uri-plugin-header-in-wordpress-5-8/ Since there's another "table-of-contents" plugin in the wporg repo, this would prevent accidental overwrites when updating from the admin.
Not strictly a Gutenberg/Block Editor problem, but that does make it vastly easier to create incompatible headings. The regex only matches plain tags: https://github.com/Automattic/table-of-contents/blob/5b3da29a3831ac7b10526394c18320b7a4004b4b/table-of-contents.php#L129 Any attributes added such as alignment...
There are some methods that may not really be necessary since this plugin isn't really OOP.
In `maintenance-mode.php`, does not address: `Functions declared in the global namespace by a theme/plugin should start with the theme/plugin prefix. Found: "current_user_can_bypass_vip_maintenance_mode".` This should be properly deprecated (#45) and replaced,...
no longer needed
Should flip it around to have a consistent prefix