node-bunyan icon indicating copy to clipboard operation
node-bunyan copied to clipboard

Uncomment Logger.prototype.close

Open iketiunn opened this issue 6 years ago • 3 comments

Closes #192 Closes #365 Closes #523

Add close method back.

Since createLogger() may create lots streams that consumes file descriptor, so you may have to close the streams in the procedure by yourself.

And yes, as the followed comment said, Typically you **don't** need to bother calling this. But it's always good to have the power control it.

iketiunn avatar Jul 23 '18 17:07 iketiunn

I'm wondering if "typically you don't need to bother calling this" is even true anyway...

In my node server, I've noticed that the log files don't get closed, even though there is no more reference to the Logger instance.

logidelic avatar Aug 20 '19 16:08 logidelic

@logidelic

I don't think this repo is active anymore.

iketiunn avatar Aug 22 '19 10:08 iketiunn

It appears not, though I wonder why as it was pretty popular...

logidelic avatar Aug 22 '19 12:08 logidelic