tremor icon indicating copy to clipboard operation
tremor copied to clipboard

feat: Chart padding prop

Open reazn opened this issue 6 months ago • 2 comments

Description

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New Feature (non-breaking change which adds functionality)
  • [ ] New Feature (BREAKING CHANGE which adds functionality)
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

How has This been tested? Through Storybook, tested many combinations which can affect the padding

Screenshots (if appropriate): Unchanged: Default chart with padding 20 paddingbefore Changed: Variable to change chart padding (in this instance, 0) paddingafter

The PR fulfills these requirements:

  • [x] It's submitted to the main branch
  • [x] When resolving a specific issue, it's referenced in the related issue section above
  • [x] My change requires a change to the documentation. (Managed by Tremor Team)
  • [x] I have added tests to cover my changes
  • [x] Check the "Allow edits from maintainers" option while creating your PR.
  • [x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • [x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

reazn avatar Dec 16 '23 23:12 reazn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 11:28pm

vercel[bot] avatar Dec 16 '23 23:12 vercel[bot]

I need this feature in my project

nicowowblez avatar Feb 10 '24 22:02 nicowowblez