tremor icon indicating copy to clipboard operation
tremor copied to clipboard

feat: onInputValueChange

Open Lary15 opened this issue 2 years ago • 3 comments

Description This PR adds onInputValueChange prop to the SearchSelect and MultiSelect component. This is a direct reproduction of #470 PR that is compatible to tremor v3

Related issue(s) #444

What kind of change does this PR introduce? (check at least one)

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New Feature (non-breaking change which adds functionality)
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

With component story examples that demonstrate the intended behavior. To see it in action, run npm run storybook and go to InputElements > SearchSelect > With On Input Value Change and InputElements > MultiSelect> With On Input Value Change.

Screenshots (if appropriate): image

The PR fulfills these requirements:

  • [x] It's submitted to the main branch
  • [x] When resolving a specific issue, it's referenced in the related issue section above
  • [x] My change requires a change to the documentation. (Managed by Tremor Team)
  • [x] I have added tests to cover my changes
  • [x] Check the "Allow edits from maintainers" option while creating your PR.
  • [x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • [x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Lary15 avatar Oct 07 '23 15:10 Lary15

cf #470

severinlandolt avatar Oct 12 '23 12:10 severinlandolt

Hey @Lary15 , I have this PR in mind, there will be more confilcts after the next version (3.10) for this PR, so we should park it until November. Will get back to it, thanks!

severinlandolt avatar Oct 18 '23 17:10 severinlandolt

@severinlandolt did you get a chance to look at this? If this has a chance to get merged soon but the conflicts are an issue I'd be happy to help out.

kldzj avatar Dec 11 '23 14:12 kldzj