tremor icon indicating copy to clipboard operation
tremor copied to clipboard

feat: allow passing label as prop

Open alexbalonperin opened this issue 9 months ago • 1 comments

Description

Pass a new prop called renderLabel?: PieLabel for Pie and renderLabel?: ImplicitLabelType for Bar/Line/Area to configure showing labels on these elements.

Related issue(s)

fixes https://github.com/tremorlabs/tremor/issues/1060

What kind of change does this PR introduce? (check at least one)

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New Feature (non-breaking change which adds functionality)
  • [ ] New Feature (BREAKING CHANGE which adds functionality)
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Screenshots (if appropriate):

Screenshot from 2024-05-25 00-11-04 Screenshot from 2024-05-25 00-11-28 Screenshot from 2024-05-25 00-11-39 Screenshot from 2024-05-25 00-11-54

The PR fulfils these requirements:

  • [x] It's submitted to the main branch
  • [x] When resolving a specific issue, it's referenced in the related issue section above
  • [x] My change requires a change to the documentation. (Managed by Tremor Team)
  • [x] I have added tests to cover my changes
  • [x] Check the "Allow edits from maintainers" option while creating your PR.
  • [x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • [x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

alexbalonperin avatar May 24 '24 15:05 alexbalonperin